Skip to content

Fix :ref: links #20139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix :ref: links #20139

merged 1 commit into from
Aug 20, 2024

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Aug 20, 2024 •
edited
Loading

image

AFAIK, this reference is also broken.

symfony-docs/components/expression_language.rst

Line 85 in 2407636

This content has been moved to the ref:`null coalescing operator <component-expression-null-coalescing-operator>`_

But I don't know how to point to the proper target. I've already tried with :doc::

-    This content has been moved to the ref:`null coalescing operator <component-expression-null-coalescing-operator>`_
+    This content has been moved to the :doc:`null coalescing operator </reference/formats/expression_language#component-expression-null-coalescing-operator>`_

@phansys phansys marked this pull request as draft August 20, 2024 21:42
@OskarStark
Copy link
Contributor

Thanks, is this the lowest branch containing these issues?

@OskarStark OskarStark mentioned this pull request Aug 20, 2024
Closed
@phansys phansys changed the base branch from 7.1 to 6.4 August 20, 2024 21:49
@phansys
Copy link
Contributor Author

phansys commented Aug 20, 2024

Thanks, is this the lowest branch containing these issues?

No, thank you. Changed target to 6.4.

@OskarStark OskarStark added this to the 6.4 milestone Aug 20, 2024
@OskarStark OskarStark marked this pull request as ready for review August 20, 2024 21:53
@OskarStark
Copy link
Contributor

Thanks for fixing this bug Javier.

@OskarStark OskarStark merged commit a86d2db into symfony:6.4 Aug 20, 2024
3 checks passed
@phansys phansys deleted the refs branch August 20, 2024 21:54
@OskarStark OskarStark mentioned this pull request Aug 20, 2024
Merged
@phansys
Copy link
Contributor Author

phansys commented Aug 20, 2024

Thank you @OskarStark!

Please, let me know if you have any clue on how to fix the broken reference in the ExpressionLanguage file.

@MrYamous
Copy link
Contributor

Thank you @OskarStark!

Please, let me know if you have any clue on how to fix the broken reference in the ExpressionLanguage file.

Hello
For sure it's not with :doc: as we're not trying to point to a page

Did you try this ?

-    This content has been moved to the ref:`null coalescing operator <component-expression-null-coalescing-operator>`_
+    This content has been moved to the :ref:`null coalescing operator <component-expression-null-coalescing-operator>`

Not sure this is the issue but this underscore has nothing to do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@phansys @OskarStark @MrYamous @carsonbot